[flang-commits] [flang] [flang][OpenMP] Try to unify induction var privatization (PR #91116)

[Kareem Ergawy via flang-commits]

ergawy wrote:

With this change, both `private(i)` and `default(private)` go through `DataSharingProcessor::doPrivatize(...)` to emit the privatization logic for `i`.

If you agree with this change, we will be able to switch delayed privatization by default (see https://github.com/llvm/llvm-project/pull/90945). With the changes in this PR, we would get a crash for cases where `default(private)` is specified for the induction variable. The crash happened because `DataSharingProcessor::cloneSymbol(...)` would return directly for `OmpPreDetermined` symbols which prevents delayed privatization from being properly applied to the induction variable.

@reviewers Please take a look and let me know what you think.

https://github.com/llvm/llvm-project/pull/91116