[flang-commits] [flang] [Flang][OpenMP] Add --cg-rewrite pass to convert-to-llvm-openmp-and-fir.fir test (PR #96530)

[Tom Eccles via flang-commits]

tblah wrote:

I think it would be best to run only the conversion in this test so that if the test ever fails it is much easier to see what the input and output of each pass was.

This could be achieved by running those intermediate passes on the IR in the test manually, then updating the test file with the results.

I think there is some argument for using IR that has been through the full pass pipeline of flang-new (capture the output of `flang-new -fc1 -emit-obj -fopenmp file.f90 -o /dev/null -mmlir --mlir-print-ir-after-all` then take the version of the IR from immediately before the conversion to LLVM). This would be the most realistic test. But at the same time I worry this could lead to overly verbose IR in the test that is harder to read and maintain.

https://github.com/llvm/llvm-project/pull/96530