[flang-commits] [flang] [llvm] [mlir] [Flang][OpenMP][MLIR] Fix common block mapping for regular and declare target link (PR #91829)

via flang-commits flang-commits at lists.llvm.org
Mon Jun 24 13:19:01 PDT 2024


agozillon wrote:

Added a couple more tests, primarily extending convert-to-llvm-openmp-and-fir.fir and adding a new test to mlir/test/Target/LLVMIR named omptarget-fortran-common-block-host.mlir.

The convert-to-llvm-openmp-and-fir.fir test is dependent on the changes in this PR: https://github.com/llvm/llvm-project/pull/96530 which just adds the cg-rewrite pass to the fir-opt command for the convert-to-llvm-openmp-and-fir.fir test, allowing DeclareOp's to be utilised in the test without verification errors. 

So I'll hold off landing the PR until that has hopefully landed. Otherwise, if no further comments over the new test additions are made or any other comments in the meantime I will go ahead with landing the PR.

https://github.com/llvm/llvm-project/pull/91829


More information about the flang-commits mailing list