[flang-commits] [flang] [Flang][OpenMP] Add --cg-rewrite pass to convert-to-llvm-openmp-and-fir.fir test (PR #96530)

[via flang-commits]

agozillon wrote:

> The fir::cg::XDeclareOp is quite a recent addition so it was not there when the test was originally written.

Thank you very much @abidh ! Would adding the cg-rewrite pass to the fir-opt argument list be the correct fix in this case then? 

The verification issue was there prior to the addition of fir::cg::XDeclareOp, however, It seems from looking at the previous code (and quickly testing it via regressing that section of code) for the DeclareOp rewrite inside of PreCGRewrtie.cpp it would be correct still, as it seems to replace all DeclareOp's with the corresponding memory reference which allows the FIR -> LLVM dialect conversion to pass without verification issues.

https://github.com/llvm/llvm-project/pull/96530