[flang-commits] [flang] [llvm] [mlir] [Flang][OpenMP][MLIR] Fix common block mapping for regular and declare target link (PR #91829)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Wed Jun 19 11:37:44 PDT 2024


kiranchandramohan wrote:

> @kiranchandramohan No real need to review this, but I've added you as a reviewer incase you wish to feed into it, but also if you know someone else that might be quite helpful to review the change set external to AMD! In particular for this change: https://github.com/llvm/llvm-project/pull/91829/files#diff-496a295679ae3c43f8651c944a1bd9dca177ad2b5e4d7121f96938024e292bc1R841 it seems reasonable to me to do, but someone with more knowledge on common blocks and their implementation may know otherwise.

The link you have given here refers to existing code. Is that correct? 
```
mlir::Operation *clonedOp = bound.getDefiningOp()->clone();
```

If you can phrase your exact question on the issue with the common block then we can request Jean or someone else to have a look.

https://github.com/llvm/llvm-project/pull/91829


More information about the flang-commits mailing list