[flang-commits] [flang] [flang][test] Fix filecheck annotation typos (PR #92387)

via flang-commits flang-commits at lists.llvm.org
Mon Jun 17 08:12:05 PDT 2024


agozillon wrote:

> > Oh, flang/test/Driver/omp-cse-region-boundary.f90 fails now too.
> > ```
> > flang/test/Driver/omp-cse-region-boundary.f90:16:18: error: CHECK-HOST-NOT: excluded string found in input
> >                           CHECK-HOST-NOT: arith.constant 10
> > <stdin>:14:15: note: found here
> >                         %c10_i32_0 = arith.constant 10 : i32
> > ```
> 
> Ping @skatrak @jsjodin @agozillon

I have a feeling this test may now be a bit redundant now with the ISA changes to the target region, CSE should function on both the host and device the same now I would imagine and I believe it'd function like it does on device currently for host and device. I imagine removal is the way to go, but amending both host and device checks to be identical would be another route @skatrak will likely know better, but I believe he is on vacation until sometime next week unfortunately

https://github.com/llvm/llvm-project/pull/92387


More information about the flang-commits mailing list