[flang-commits] [clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

[Tarun Prabhu via flang-commits]

================
@@ -371,7 +371,7 @@ static mlir::LogicalResult convertFortranSourceToMLIR(
       ctx, semanticsContext, defKinds, semanticsContext.intrinsics(),
       semanticsContext.targetCharacteristics(), parsing.allCooked(),
       targetTriple, kindMap, loweringOptions, envDefaults,
-      semanticsContext.languageFeatures(), targetMachine);
+      semanticsContext.languageFeatures(), targetMachine, "");
----------------
tarunprabhu wrote:

NIT: Would it be worth creating a `constexpr const char* tuneCPU = ""` and using that in place of the empty string literal here? It might make it clear what that parameter is. 

I don't have a strong opinion on this one way or another. If you or anyone else has a different opinion, I'm happy to defer to it. 

https://github.com/llvm/llvm-project/pull/95043