[flang-commits] [flang] [flang][OpenMP] Lower `target .. private(..)` to `omp.private` ops (PR #94195)

Kareem Ergawy via flang-commits flang-commits at lists.llvm.org
Thu Jun 6 20:50:02 PDT 2024


ergawy wrote:

> Would it make sense to add a TODO/`Not Yet Implemented Error` for all target directives for firstprivate clauses that can be deferred?

`firstprivate` is currrently still a TODO for `target`:
```c++
  cp.processTODO<clause::Allocate, clause::Defaultmap, clause::Firstprivate,
                 clause::InReduction, clause::Reduction,
                 clause::UsesAllocators>(loc,
                                         llvm::omp::Directive::OMPD_target);
```

This PR is only for `private`. Let me know if I misunderstood what you mean.

I also added a more extensive test.

https://github.com/llvm/llvm-project/pull/94195


More information about the flang-commits mailing list