[flang-commits] [flang] [Flang][OpenMP][Lower] Add lowering support of OpenMP distribute to MLIR (PR #67798)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Thu Jun 6 12:20:41 PDT 2024


kiranchandramohan wrote:

> > Some of the tests do not check for omp.loop_nest (in loop-combined.f90). Is that missed accidentally or by design?
> 
> Thank you Kiran for giving this another look. In all these cases an `omp.loop_nest` is expected, but that test mainly just checks loop wrappers, which is also the case for if-clause.f90. The thinking behind it is that the existence of a single loop operation closely nested inside all loop wrappers is tested for each of the wrappers separately (distribute.f90, wsloop*.f90, etc) so I didn't think it to be necessary for combined/composite construct tests.
> 
> I agree it doesn't hurt to add these checks though, but maybe it's something I could do as a follow-up PR to update both tests rather than making unrelated test changes here. Let me know if that works for you.

That is fine.

https://github.com/llvm/llvm-project/pull/67798


More information about the flang-commits mailing list