[flang-commits] [flang] [flang][OpenMP] Lower `target .. private(..)` to `omp.private` ops (PR #94195)

[Kareem Ergawy via flang-commits]

ergawy wrote:

Thanks for taking a look @kiranchandramohan.

> Could you add a few more tests?
> -> With a default private.

I might have missed something, but `target` does not support the `default` clause, right?

> -> With three different types of privates.

You mean different types of variables; e.g. primitive, allocatable, pointer, array, etc? Or something else?

> Did you get a chance to discuss with @mjklemm about how privatisation works for tasks and since target has some task like properties whether we need something more than inlining?

Not yet. Will do that. (cc @mjklemm & @pranavb-ca since we discussed `target` support in MLIR -> LLVM translation layer)

https://github.com/llvm/llvm-project/pull/94195