[flang-commits] [clang] [lld] [llvm] [flang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

[Alex Voicu via flang-commits]

================
@@ -139,10 +139,10 @@ bool AMDGPURemoveIncompatibleFunctions::checkFunction(Function &F) {
   const GCNSubtarget *ST =
       static_cast<const GCNSubtarget *>(TM->getSubtargetImpl(F));
 
-  // Check the GPU isn't generic. Generic is used for testing only
-  // and we don't want this pass to interfere with it.
+  // Check the GPU isn't generic or generic-hsa. Generic is used for testing
+  // only and we don't want this pass to interfere with it.
   StringRef GPUName = ST->getCPU();
-  if (GPUName.empty() || GPUName.contains("generic"))
+  if (GPUName.empty() || GPUName.starts_with("generic"))
----------------
AlexVlx wrote:

Are we sure this is correct? The existing issue (as far as I can tell) is that we never really implemented `generic`, so it'd just end up as some specific. However, with generic targets, it appears that the pass would actually make sense / apply / have some use?

https://github.com/llvm/llvm-project/pull/76955