[flang-commits] [flang] [Flang][OpenMP] Remove space before :: in member function definition,… (PR #78205)
via flang-commits
flang-commits at lists.llvm.org
Mon Jan 15 11:21:18 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-flang-openmp
Author: Krzysztof Parzyszek (kparzysz)
<details>
<summary>Changes</summary>
… NFC
The names were
```
bool DataSharingProcessor ::needBarrier()
void DataSharingProcessor ::insertBarrier()
```
It seems like clang-format treats those as references to the global namespace instead of separators in a qualified name.
---
Full diff: https://github.com/llvm/llvm-project/pull/78205.diff
1 Files Affected:
- (modified) flang/lib/Lower/OpenMP.cpp (+2-2)
``````````diff
diff --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp
index 4f7c99a6d2b840..c770d1c60718c3 100644
--- a/flang/lib/Lower/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP.cpp
@@ -290,7 +290,7 @@ void DataSharingProcessor::collectSymbolsForPrivatization() {
TODO(converter.getCurrentLocation(), "Collapse clause with lastprivate");
}
-bool DataSharingProcessor ::needBarrier() {
+bool DataSharingProcessor::needBarrier() {
for (const Fortran::semantics::Symbol *sym : privatizedSymbols) {
if (sym->test(Fortran::semantics::Symbol::Flag::OmpFirstPrivate) &&
sym->test(Fortran::semantics::Symbol::Flag::OmpLastPrivate))
@@ -299,7 +299,7 @@ bool DataSharingProcessor ::needBarrier() {
return false;
}
-void DataSharingProcessor ::insertBarrier() {
+void DataSharingProcessor::insertBarrier() {
// Emit implicit barrier to synchronize threads and avoid data races on
// initialization of firstprivate variables and post-update of lastprivate
// variables.
``````````
</details>
https://github.com/llvm/llvm-project/pull/78205
More information about the flang-commits
mailing list