[flang-commits] [flang] [clang] [flang] Fix fveclib on Darwin (PR #77605)
Tom Eccles via flang-commits
flang-commits at lists.llvm.org
Wed Jan 10 07:37:53 PST 2024
https://github.com/tblah approved this pull request.
Makes sense. For reference, here I was trying to reproduce the logic from https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L5364 and https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Darwin.cpp#L752.
In light of your fix, it does look like the clang logic would have rendered the argument on darwin (as well as possibly adding `-framework Accelerate`). So this LGTM.
Thanks for catching my mistake!
https://github.com/llvm/llvm-project/pull/77605
More information about the flang-commits
mailing list