[flang-commits] [flang] [Flang][OpenMP] Disable declarate target tests on Windows (PR #77306)

[Kiran Chandramohan via flang-commits]

kiranchandramohan wrote:

> I'm not so familiar with XFAIL, but doesn't it just check that the test fails and if it does then it's a "success"? Wouldn't that mean these tests would still sporadically fail, as they were passing sometimes previously on windows if I recall correctly? Sorry, I am a little unfamiliar with XFAIL and a lot of the lit functionality still, so I am very likely incorrect and misunderstanding something.

Yes, you are correct. XFAIL is not the right solution here. I have created another patch to mark these tests as UNSUPPORTED (https://github.com/llvm/llvm-project/pull/77325)

> 2\. As I mentioned in the linked bug, the issue does not seem related to these tests in particular. Do you have data showing otherwise?

I do not have. But I have seen these tests failing and others have reported as well. This has been happening for a while and I believe it is an unnecessary distraction for other contributors to LLVM.

https://github.com/llvm/llvm-project/pull/77306