[flang-commits] [flang] [Flang] Allow Intrinsic simpification with min/maxloc dim and scalar result (PR #81619)
Tom Eccles via flang-commits
flang-commits at lists.llvm.org
Tue Feb 27 09:10:53 PST 2024
https://github.com/tblah approved this pull request.
Okay I had a look at the runtime library and I don't think that catches a dynamically out of bounds dim either. So I think this is okay. +1 from me
I don't think a compile time check for constants is right here (except maybe as an assertion). This sort of thing should be caught in semantics so we can generate a properly formatted warning/error. What I would have considered was a runtime check for DIM, but as the runtime library code appears not to be doing that, I think it is okay not to do that here either.
Thanks for your work on this
https://github.com/llvm/llvm-project/pull/81619
More information about the flang-commits
mailing list