[flang-commits] [flang] [Flang][MLIR][OpenMP] Create a deferred declare target marking process for Bridge.cpp (PR #78502)
via flang-commits
flang-commits at lists.llvm.org
Thu Feb 22 10:30:18 PST 2024
================
@@ -3959,42 +4015,16 @@ static void genOMP(Fortran::lower::AbstractConverter &converter,
for (const DeclareTargetCapturePair &symClause : symbolAndClause) {
mlir::Operation *op = mod.lookupSymbol(
converter.mangleName(std::get<Fortran::semantics::Symbol>(symClause)));
- // There's several cases this can currently be triggered and it could be
- // one of the following:
- // 1) Invalid argument passed to a declare target that currently isn't
- // captured by a frontend semantic check
- // 2) The symbol of a valid argument is not correctly updated by one of
- // the prior passes, resulting in missing symbol information
- // 3) It's a variable internal to a module or program, that is legal by
- // Fortran OpenMP standards, but is currently unhandled as they do not
- // appear in the symbol table as they are represented as allocas
+
+ // Some symbols are deferred until later in the module, these are handled
+ // apon finalization of the module for OpenMP inside of Bridge, so we simply
----------------
agozillon wrote:
I think you've corrected me on this exact same spelling mistake a few times now... thank you very much :D might be time to integrate a spell checker into my IDE... especially for the documentation component
https://github.com/llvm/llvm-project/pull/78502
More information about the flang-commits
mailing list