[flang-commits] [flang] [mlir] [WIP] Delayed privatization. (PR #79862)

[Kareem Ergawy via flang-commits]

================
@@ -3505,6 +3505,18 @@ struct ZeroOpConversion : public FIROpConversion<fir::ZeroOp> {
   }
 };
 
+class DeclareOpConversion : public FIROpConversion<fir::DeclareOp> {
----------------
ergawy wrote:

While experimenting with delayed privation for `hlfir` (so far I have been experimenting with `fir`), I came across a small issue which is that `fir.declare` is not support when converting from `fir` to `mlir` dialect. That's why I had to copy this conversion pattern from `PreCGRewrite.cpp`. Since `DeclareOpConversion` does not convert to op in the `fir::cg` dialect, I think it would be nice to move it here to make conversion from `fir` to `llvm` dialect more complete.

Do you folks have any input on this?

https://github.com/llvm/llvm-project/pull/79862