[flang-commits] [flang] [NFC] Adding missing flang tests for LTO bugfix (PR #80417)

Andrzej WarzyƄski via flang-commits flang-commits at lists.llvm.org
Sun Feb 4 10:58:44 PST 2024


banach-space wrote:

Thanks for this patch!

> The fix also covered flang, as it's handled in CommonArgs.cpp, but no testing was added for flang.

>From your summary, this particular logic in CommonArgs.cpp is already tested in Clang. IMHO, we should avoid duplicating tests like this. Sometimes that's tricky to avoid, especially when enabling new options in Flang. However, in this case, it seems quite apparent that testing in Flang is not going to increase the test coverage. I might be missing something though.

https://github.com/llvm/llvm-project/pull/80417


More information about the flang-commits mailing list