[flang-commits] [flang] [mlir] [WIP] Delayed privatization. (PR #79862)

Leandro Lupori via flang-commits flang-commits at lists.llvm.org
Thu Feb 1 11:40:42 PST 2024


================
@@ -2463,12 +2518,12 @@ static OpTy genOpWithBody(Fortran::lower::AbstractConverter &converter,
                           Fortran::lower::pft::Evaluation &eval, bool genNested,
                           mlir::Location currentLocation, bool outerCombined,
                           const Fortran::parser::OmpClauseList *clauseList,
-                          Args &&...args) {
+                          DataSharingProcessor *dsp, Args &&...args) {
----------------
luporl wrote:

It seems to me that any change in the parameters of `genOpWithBody` and/or `createBodyOfOp` requires many changes to OpenMP.cpp.
Also, in the call sites, many arguments are simply set to `false` or `nullptr`.

If others agree, in a separate or future patch, can we consider to wrap these functions inside a new class, that may have more than one constructor, with default arguments? It would then be possible to call the functions with only `Args &&...`.

https://github.com/llvm/llvm-project/pull/79862


More information about the flang-commits mailing list