[flang-commits] [flang] [mlir] [mlir][Transforms] Support 1:N mappings in `ConversionValueMapping` (PR #116524)

Matthias Springer via flang-commits flang-commits at lists.llvm.org
Tue Dec 24 01:59:27 PST 2024


================
@@ -1478,34 +1497,12 @@ Value ConversionPatternRewriterImpl::findOrBuildReplacementValue(
   }
   Value castValue = buildUnresolvedMaterialization(
       MaterializationKind::Source, computeInsertPoint(repl), value.getLoc(),
----------------
matthias-springer wrote:

re: Using `value` as an insertion point. I just gave this a try, but it doesn't work. One problem is with block signature conversions. E.g.: a memref is replaced with the elements that make up a memref descriptor (during MemRef -> LLVM). In that case, `computeInsertionPoint(value)` would return the old block (that is going to be erased). The materialization must be inserted in the new block.


https://github.com/llvm/llvm-project/pull/116524


More information about the flang-commits mailing list