[flang-commits] [flang] [flang][cuda] Additional update to ExternalNameConversion (PR #119276)

via flang-commits flang-commits at lists.llvm.org
Mon Dec 9 14:06:11 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff f9e11501841fc602488fea78b88910eab7d4d396 a136c793e316bcd00f6ff34243b585f93573cdec --extensions cpp -- flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp b/flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp
index eaa40a35e3..4f6974ee52 100644
--- a/flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp
+++ b/flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp
@@ -62,11 +62,10 @@ void ExternalNameConversionPass::runOnOperation() {
 
   auto processFctOrGlobal = [&](mlir::Operation &funcOrGlobal) {
     auto symName = funcOrGlobal.getAttrOfType<mlir::StringAttr>(
-              mlir::SymbolTable::getSymbolAttrName());
+        mlir::SymbolTable::getSymbolAttrName());
     auto deconstructedName = fir::NameUniquer::deconstruct(symName);
     if (fir::NameUniquer::isExternalFacingUniquedName(deconstructedName)) {
-      auto newName =
-          mangleExternalName(deconstructedName, appendUnderscoreOpt);
+      auto newName = mangleExternalName(deconstructedName, appendUnderscoreOpt);
       auto newAttr = mlir::StringAttr::get(context, newName);
       mlir::SymbolTable::setSymbolName(&funcOrGlobal, newAttr);
       auto newSymRef = mlir::FlatSymbolRefAttr::get(newAttr);
@@ -82,7 +81,8 @@ void ExternalNameConversionPass::runOnOperation() {
         processFctOrGlobal(op);
       } else if (auto gpuMod = mlir::dyn_cast<mlir::gpu::GPUModuleOp>(op)) {
         for (auto &gpuOp : gpuMod.getBodyRegion().front())
-          if (mlir::isa<mlir::func::FuncOp, fir::GlobalOp, mlir::gpu::GPUFuncOp>(gpuOp))
+          if (mlir::isa<mlir::func::FuncOp, fir::GlobalOp,
+                        mlir::gpu::GPUFuncOp>(gpuOp))
             processFctOrGlobal(gpuOp);
       }
     }
@@ -104,7 +104,9 @@ void ExternalNameConversionPass::runOnOperation() {
             remap != remappings.end()) {
           mlir::SymbolRefAttr symAttr = mlir::FlatSymbolRefAttr(remap->second);
           if (mlir::isa<mlir::gpu::LaunchFuncOp>(nestedOp))
-            symAttr = mlir::SymbolRefAttr::get(symRef.getRootReference(), {mlir::FlatSymbolRefAttr(remap->second)});
+            symAttr = mlir::SymbolRefAttr::get(
+                symRef.getRootReference(),
+                {mlir::FlatSymbolRefAttr(remap->second)});
           updates.emplace_back(std::pair<mlir::StringAttr, mlir::SymbolRefAttr>{
               attr.getName(), symAttr});
         }

``````````

</details>


https://github.com/llvm/llvm-project/pull/119276


More information about the flang-commits mailing list