[flang-commits] [flang] [llvm] [flang][OpenMP]Add support for fail clause (PR #118683)

[Kiran Chandramohan via flang-commits]

================
@@ -114,6 +114,11 @@ class SemanticsVisitor : public virtual BaseChecker, public virtual C... {
     context_.set_location(std::nullopt);
   }
 
+  // This is necessary to avoid "walking" into the Fail clause,
+  // which confuses the CheckAllowed into thinking there's another
+  // memoryorder, when it's actually the argument to the fail clause.
+  bool Pre(const parser::OmpFailClause &) { return false; }
----------------
kiranchandramohan wrote:

Would this disallow any future checks for the OmpFailClause?

What are the alternatives here?
Marking the MemoryOrder values for OmpFail as an ENUM or something?
Alternative, would be to manually check the clauses having MemoryOrder components in check-omp-structure.cpp.

https://github.com/llvm/llvm-project/pull/118683