[flang-commits] [flang] [Flang][OpenMP] Make boxed procedure pass aware of OpenMP private ops (PR #118261)

[Kiran Chandramohan via flang-commits]

kiranchandramohan wrote:

Thanks @jeanPerier for the quick response.

> I wonder if the generic fix is not to remove the "op->getDialect() == firDialect" in the case just above. I do not recall the rational of limiting it to fir ops.

This is a good idea. The fir dialect-specific check currently converts the results. For this particular case, see the next point.

> (the next bag of issue I see would come from FIR type inside attributes of operations not handled here. 

The type is stored as an attribute in the OpenMP `PrivateClauseOp`, which is why a separate else statement is required here.

Some kind of generalization might still be required for the other declaration/recipe-based operations.

https://github.com/llvm/llvm-project/pull/118261