[flang-commits] [flang] [OpenMP]Update use_device_clause lowering (PR #101703)
Sergio Afonso via flang-commits
flang-commits at lists.llvm.org
Wed Aug 21 06:35:16 PDT 2024
================
@@ -796,90 +845,31 @@ static void genBodyOfTargetOp(
mlir::omp::TargetOp &targetOp,
llvm::ArrayRef<const semantics::Symbol *> mapSyms,
llvm::ArrayRef<mlir::Location> mapSymLocs,
- llvm::ArrayRef<mlir::Type> mapSymTypes, DataSharingProcessor &dsp,
+ llvm::ArrayRef<mlir::Type> mapSymTypes,
const mlir::Location ¤tLocation, const ConstructQueue &queue,
- ConstructQueue::const_iterator item) {
+ ConstructQueue::const_iterator item, DataSharingProcessor &dsp) {
assert(mapSymTypes.size() == mapSymLocs.size());
fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder();
mlir::Region ®ion = targetOp.getRegion();
+ mlir::Block *regionBlock = nullptr;
llvm::SmallVector<mlir::Type> allRegionArgTypes;
- mergePrivateVarsInfo(targetOp, mapSymTypes,
+ llvm::SmallVector<mlir::Location> allRegionArgLocs;
+ mergePrivateVarsInfo(mlir::cast<mlir::omp::TargetOp>(targetOp), mapSymTypes,
----------------
skatrak wrote:
Nit: There are several instances of this in this function. It's not necessary because `targetOps` is already of that type.
```suggestion
mergePrivateVarsInfo(targetOp, mapSymTypes,
```
https://github.com/llvm/llvm-project/pull/101703
More information about the flang-commits
mailing list