[flang-commits] [flang] [RFC][flang] Replace special symbols in uniqued global names. (PR #104859)

via flang-commits flang-commits at lists.llvm.org
Wed Aug 21 02:19:54 PDT 2024


jeanPerier wrote:

> Thank you for the review, Jean! I tried using `X` earlier in the compilation pipeline, first, but then I failed to cleanly resolve the lowercasing that is done for the symbol names. So I decided to follow your reasoning in [#71338 (comment)](https://github.com/llvm/llvm-project/pull/71338#issuecomment-1795750355) and put this into a pass. I tried combining the logic with the `ExternalNamesConversion` pass, but that did not look clean to me and I ended up separating it into a new pass.

Thanks for the link and explanation. You approach looks good to me.


https://github.com/llvm/llvm-project/pull/104859


More information about the flang-commits mailing list