[flang-commits] [flang] [flang][test] Run Driver/fveclib-codegen.f90 for aarch64 and x86_64 (PR #103730)

Andrzej Warzyński via flang-commits flang-commits at lists.llvm.org
Tue Aug 20 10:19:01 PDT 2024


================
@@ -1,6 +1,7 @@
 ! test that -fveclib= is passed to the backend
 ! -target aarch64 so that ArmPL is available
----------------
banach-space wrote:

Thanks for clarifying!

> To test ArmPL we have to have an aarch64 target otherwise the driver will generate an error. 

Right, but that's not what this comment is saying:

> ! -target aarch64 so that ArmPL is available

Also, looks like this is testing LIBMVEC rather than ArmPl. 

IMHO, referring to something that's not being tested is confusing :) Let's either add ArmPl or remove this comment 🙏🏻

https://github.com/llvm/llvm-project/pull/103730


More information about the flang-commits mailing list