[flang-commits] [flang] [RFC][flang] Replace special symbols in uniqued global names. (PR #104859)

[Slava Zakharin via flang-commits]

vzakhari wrote:

> Code looks good to me (small nit about an IO case probably not very relevant to your use case). I am wondering a bit if we should just use X right away as a separator rather than use a rewrite pass to avoid the pass complexity, but "." is more readable in the IR and the flexibility makes some sense.

Thank you for the review, Jean!  I tried using `X` earlier in the compilation pipeline, first, but then I failed to cleanly resolve the lowercasing that is done for the symbol names.  So I decided to follow your reasoning in https://github.com/llvm/llvm-project/pull/71338#issuecomment-1795750355 and put this into a pass.  I tried combining the logic with the `ExternalNamesConversion` pass, but that did not look clean to me and I ended up separating it into a new pass.

https://github.com/llvm/llvm-project/pull/104859