[flang-commits] [flang] [Flang][OpenMP][Lower] NFC: Clause lowering cleanup (PR #103058)

[Sergio Afonso via flang-commits]

skatrak wrote:

Thank you @Meinersbur for the review!

> This makes this patch non-NFC. I assume this is for combined/composite constructs (supported -> applicable).

Not particularly, that's referring to the `allocate` clause when present in the list of clauses for `simd` and the `reduction` clause for `target`. These constructs don't accept these clauses, so they shouldn't trigger a TODO error. At the moment we just ignore clauses that don't apply to the construct we're lowering, so removing them from the list of TODOs would give the expected behavior.

I think that, once #102613 is merged, we could think about actually adding asserts to lowering when an inapplicable clause is attached to a construct (one that the construct can't receive in any case).

I'll update the PR title, since there's indeed some minor behavior change as a result.

https://github.com/llvm/llvm-project/pull/103058