[flang-commits] [flang] [Flang][Runtime] Handle missing definitions in <cfenv> (PR #101242)

via flang-commits flang-commits at lists.llvm.org
Mon Aug 12 16:35:19 PDT 2024


https://github.com/vdonaldson approved this pull request.

[I've been away from work for several weeks, and I believe several of the other reviewers have been and may still be away as well.]

I'm not familiar with the cited environments (emscripten, musl). I'm therefore not sure if the changes here are just a modest implementation detail. If the changes have consequences for compiler correctness associated with the discussion in f23 (or f18) Clause 17.1 _Overview of IEEE arithmetic support_, then the implementations of _IEEE_SUPPORT_FLAG_ and _IEEE_SUPPORT_HALTING_ from Clause 17.11 could be affected.

With that caveat, the changes look ok to me for addressing the stated problem. It would be good to give other folks more opportunity to comment if possible though.

https://github.com/llvm/llvm-project/pull/101242


More information about the flang-commits mailing list