[flang-commits] [flang] bba491f - [flang][NFC] Add missing sourceBox documentation in embox ops (#101221)

via flang-commits flang-commits at lists.llvm.org
Fri Aug 2 11:20:25 PDT 2024


Author: Valentin Clement (バレンタイン クレメン)
Date: 2024-08-02T11:20:22-07:00
New Revision: bba491f895ad12ac4847cce5e7e819110b87246a

URL: https://github.com/llvm/llvm-project/commit/bba491f895ad12ac4847cce5e7e819110b87246a
DIFF: https://github.com/llvm/llvm-project/commit/bba491f895ad12ac4847cce5e7e819110b87246a.diff

LOG: [flang][NFC] Add missing sourceBox documentation in embox ops (#101221)

Just noticed that `sourceDoc` was not documented in embox operations
description. this patch just add the documentation.

Added: 
    

Modified: 
    flang/include/flang/Optimizer/CodeGen/CGOps.td
    flang/include/flang/Optimizer/Dialect/FIROps.td

Removed: 
    


################################################################################
diff  --git a/flang/include/flang/Optimizer/CodeGen/CGOps.td b/flang/include/flang/Optimizer/CodeGen/CGOps.td
index 34c5dc07284f0..f65291fc64c17 100644
--- a/flang/include/flang/Optimizer/CodeGen/CGOps.td
+++ b/flang/include/flang/Optimizer/CodeGen/CGOps.td
@@ -48,6 +48,8 @@ def fircg_XEmboxOp : fircg_Op<"ext_embox", [AttrSizedOperandSegments]> {
        - substring: A substring operator (offset, length) for CHARACTER.
        - LEN type parameters: A vector of runtime LEN type parameters that
          describe an correspond to the elemental derived type.
+       - sourceBox: A box to read information from such as CFI type,
+         type descriptor or element size to populate the new descriptor.
        - allocator_idx: specify special allocator to use.
 
     The memref and shape arguments are mandatory. The rest are optional.

diff  --git a/flang/include/flang/Optimizer/Dialect/FIROps.td b/flang/include/flang/Optimizer/Dialect/FIROps.td
index 7856fa7d90184..04f5fedf2783f 100644
--- a/flang/include/flang/Optimizer/Dialect/FIROps.td
+++ b/flang/include/flang/Optimizer/Dialect/FIROps.td
@@ -782,6 +782,8 @@ def fir_EmboxOp : fir_Op<"embox", [NoMemoryEffect, AttrSizedOperandSegments]> {
           lower bounds and extents may not be known until runtime),
         - slice: an array section can be described with a slice triple,
         - typeparams: for emboxing a derived type with LEN type parameters,
+        - sourceBox: A box to read information from such as CFI type,
+          type descriptor or element size to populate the new descriptor.
         - accessMap: unused/experimental.
         - allocator_idx: specify special allocator to use.
   }];


        


More information about the flang-commits mailing list