[flang-commits] [flang] [Flang][OpenMP] Align map clause generation and fix issue with non-shared allocations for assumed shape/size descriptor types (PR #97855)
via flang-commits
flang-commits at lists.llvm.org
Fri Aug 2 05:49:00 PDT 2024
================
@@ -341,11 +341,11 @@ def LoopVersioning : Pass<"loop-versioning", "mlir::func::FuncOp"> {
}
def OMPMapInfoFinalizationPass
- : Pass<"omp-map-info-finalization"> {
+ : Pass<"omp-map-info-finalization", "mlir::func::FuncOp"> {
----------------
agozillon wrote:
Actually looking a bit further into it, it's still ran as a FuncOp pass, I've just made it a little bit more explicit with these additions. Not what I would have expected in this case! But in either case, happy to make it a ModuleOp pass, I've yet to encounter any race condition issues, but considering the pass is in flux quite a bit, it's likely better safe than sorry and we can convert it to a FuncOp pass and iron out any possible issues when it's a little more stable.
https://github.com/llvm/llvm-project/pull/97855
More information about the flang-commits
mailing list