[flang-commits] [flang] [llvm] [mlir] [mlir] Mark `isa/dyn_cast/cast/...` member functions deprecated. (PR #89998)

[via flang-commits]

dyung wrote:

Hi @chsigg, this change is causing a build failure on a bot:

https://lab.llvm.org/buildbot/#/builders/216/builds/38157/steps/6/logs/stdio
```
17.940 [2051/64/2510] Building CXX object lib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\VPlanAnalysis.cpp.obj
FAILED: lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanAnalysis.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Transforms\Vectorize -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\Transforms\Vectorize -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\VPlanAnalysis.cpp.obj /Fdlib\Transforms\Vectorize\CMakeFiles\LLVMVectorize.dir\LLVMVectorize.pdb /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\Transforms\Vectorize\VPlanAnalysis.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/ADT/TypeSwitch.h(78): error C2059: syntax error: ')'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/ADT/TypeSwitch.h(80): error C2059: syntax error: ')'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/ADT/TypeSwitch.h(79): error C2760: syntax error: unexpected token 'return', expected ';'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/ADT/TypeSwitch.h(79): note: This diagnostic occurred in the compiler generated function 'decltype(auto) llvm::detail::TypeSwitchBase<DerivedT,T>::castValue(ValueT &&,enable_if<is_detected<llvm::detail::TypeSwitchBase<DerivedT,T>::has_dyn_cast_t,ValueT,CastT>::value,void>::type *)'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/ADT/TypeSwitch.h(95): note: see reference to class template instantiation 'llvm::detail::TypeSwitchBase<DerivedT,T>' being compiled
```
Can you take a look and revert if you need time to investigate?

https://github.com/llvm/llvm-project/pull/89998