[flang-commits] [flang] 8dcb90b - Revert "[Flang] Add fallthrough annotations in visit.h (#90014)"

Alexander Shaposhnikov via flang-commits flang-commits at lists.llvm.org
Thu Apr 25 12:28:39 PDT 2024


Author: Alexander Shaposhnikov
Date: 2024-04-25T19:26:41Z
New Revision: 8dcb90b083f1dd681478c5d036e52785bafcc205

URL: https://github.com/llvm/llvm-project/commit/8dcb90b083f1dd681478c5d036e52785bafcc205
DIFF: https://github.com/llvm/llvm-project/commit/8dcb90b083f1dd681478c5d036e52785bafcc205.diff

LOG: Revert "[Flang] Add fallthrough annotations in visit.h (#90014)"

This reverts commit eb05a2e89dccec734625aa336b553197b75f2340.
(The comming broke Fortran runtime builders:
https://lab.llvm.org/buildbot/#/builders/267/builds/1277)

Added: 
    

Modified: 
    flang/include/flang/Common/visit.h

Removed: 
    


################################################################################
diff  --git a/flang/include/flang/Common/visit.h b/flang/include/flang/Common/visit.h
index 7fe9ff839917c9..4d0897301e01db 100644
--- a/flang/include/flang/Common/visit.h
+++ b/flang/include/flang/Common/visit.h
@@ -23,7 +23,6 @@
 
 #include "variant.h"
 #include "flang/Common/api-attrs.h"
-#include "llvm/Support/Compiler.h"
 #include <type_traits>
 
 namespace Fortran::common {
@@ -41,17 +40,11 @@ inline RT_API_ATTRS RESULT Log2VisitHelper(
       return visitor(std::get<(LOW + N)>(std::forward<VARIANT>(u))...); \
     }
       VISIT_CASE_N(1)
-      LLVM_FALLTHROUGH;
       VISIT_CASE_N(2)
-      LLVM_FALLTHROUGH;
       VISIT_CASE_N(3)
-      LLVM_FALLTHROUGH;
       VISIT_CASE_N(4)
-      LLVM_FALLTHROUGH;
       VISIT_CASE_N(5)
-      LLVM_FALLTHROUGH;
       VISIT_CASE_N(6)
-      LLVM_FALLTHROUGH;
       VISIT_CASE_N(7)
 #undef VISIT_CASE_N
     }


        


More information about the flang-commits mailing list