[flang-commits] [flang] [flang][OpenMP] Add OpenMP versions to some tests (PR #89295)
Krzysztof Parzyszek via flang-commits
flang-commits at lists.llvm.org
Mon Apr 22 09:30:24 PDT 2024
kparzysz wrote:
> Would it be OK to assume the latest version i.e. 5.2 or 6 and implement this? Traditionally, in Flang, there has been no version-specific handling. So this might need a quick discussion with others. Also, what is the scope of the versioning that you are planning? Is it starting from 4.5 or 5.0? Or is it starting from 1.1?
In my current work I take whatever version is present in the MLIR module (which I think is 1.1 by default). The function I mentioned is already there, I'm just calling it. I can use any version with it, I'm not blocked on that.
I was actually thinking about creating an RFC about automatically generating the OMP.td file from the JSON files in the spec. There we'd consume the JSON files from all spec versions, and add version numbers to each directive. We already have versioned clauses, so I thought we could also have versioned directives. Do you think that's worth doing?
https://github.com/llvm/llvm-project/pull/89295
More information about the flang-commits
mailing list