[flang-commits] [flang] [flang][OpenMP] Fix construct privatization in default clause (PR #72510)

Leandro Lupori via flang-commits flang-commits at lists.llvm.org
Mon Apr 1 10:53:19 PDT 2024


luporl wrote:

> Thanks @luporl . I have pushed the change. I think a similar treatment (to deeply nested constructs) is also needed when we manipulate symbols while resolving directives. However, that problem has already been resolved with your change at #85989, where `shared(z)` uses the parent's copy. Once both the changes go in, the problem should be solved. Is that fine with you? Or should I merge both changes into one patch and then raise a review for the same?

@NimishMishra, I think that, if it's not too much work, it would be nice to move from #85989 to this change the part that filters out symbols that are out of `eval` scope. It would be the `if (clauseScopes.contains(&sym->owner())) symbols.insert(sym)` part and all of its dependencies. This would avoid a regression in default clause handling, while #85989 doesn't land.


https://github.com/llvm/llvm-project/pull/72510


More information about the flang-commits mailing list