[flang-commits] [flang] [flang] Allow lowering of sub-expressions to be overridden (PR #69944)

[Kiran Chandramohan via flang-commits]

kiranchandramohan wrote:

Thanks @jeanPerier for this extension of the expression lowering infrastructure. I agree that this is much cleaner than the custom lowering. The only question I have is whether this addition of state to expression lowering will make any future parallel lowering of expressions impossible.

> Thanks for this. In my opinion, this seems cleaner. Pinging @kiranchandramohan for his take on how to move further on this.

I think you have to work with Jean on how to merge this patch. Whether the current patch can go in as it is with the failing OpenMP & OpenACC tests XFAILed, or only the expression lowering infrastructure improvement goes in and then you can update the OpenMP/OpenACC lowering code using this new infrastructure.



https://github.com/llvm/llvm-project/pull/69944