[flang-commits] [flang] [flang][codegen] Update FIR codegen to use mlir.llvm opaque pointers (PR #69692)

Markus Böck via flang-commits flang-commits at lists.llvm.org
Fri Oct 20 03:05:14 PDT 2023


================
@@ -328,16 +320,15 @@ mlir::Type LLVMTypeConverter::convertSequenceType(SequenceType seq) const {
     if (!seq.hasDynamicExtents())
       return baseTy;
   }
-  return mlir::LLVM::LLVMPointerType::get(baseTy);
+  return baseTy;
----------------
zero9178 wrote:

Is `baseTy` guaranteed to be a pointer type here? Looking at the diff it looks like it should return just `mlir::LLVM::LLVMPointerType::get(baseTy.getContext()))`

https://github.com/llvm/llvm-project/pull/69692


More information about the flang-commits mailing list