[flang-commits] [flang] [Flang] Set address space during FIR pointer-like types lowering (PR #69599)

[via flang-commits]

https://github.com/jeanPerier commented:

Not an address space expert, but looks reasonable to me. However, this is far from the only place where LLVMPointerType::get is called when lowering FIR. I just made a patch to update our codegen to use opaque pointers https://github.com/llvm/llvm-project/pull/69692, and there are quite a few other places? Don't you need to do it in every places?

Although, wouldn't it be more generic to do this during the LLVM Dialect to LLVM IR translation to cover all the passes/translations/dialects that may generate llvm.ptr type inside a module with a non default addressing space?

https://github.com/llvm/llvm-project/pull/69599