[flang-commits] [flang] [flang] Put ISO_Fortran_binding.h where it can be easily used (PR #68756)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Thu Oct 12 12:06:24 PDT 2023


================
@@ -64,6 +64,7 @@ set(FLANG_TEST_DEPENDS
   FortranRuntime
   Fortran_main
   FortranDecimal
+  clang
----------------
kiranchandramohan wrote:

I generally use `check-flang` to build flang. Also, was not sure whether to add a dependency with the whole of clang for just one test.

Yes, we have to add `clang` to `config.available_features` for REQUIRES to work. 

For the dependency with clang, Do we really want to check with the `clang` just built or is it sufficient to check with the clang installed on the system? Also, is it OK to check with the system compiler?

The OpenMP runtime library checks for the presence of `flang` for running an offload test. Would that be a possible way?
https://reviews.llvm.org/D158546

Another reference might include the way the runtime no dependency on C++ libs is checked.
https://reviews.llvm.org/D104290

https://github.com/llvm/llvm-project/pull/68756


More information about the flang-commits mailing list