[flang-commits] [flang] [OpenMP][Flang] Add "IsolatedFromAbove" trait to omp.target (PR #67164)

[Akash Banerjee via flang-commits]

TIFitis wrote:

> And as a small aside, have you tested that the patch series works with the runtime tests in: https://github.com/llvm/llvm-project/tree/main/openmp/libomptarget/test/offloading/fortran
> 
> I mainly ask just to be sure, as it seems to take the stars aligning for these to execute unquestioned on my machine (perhaps the incorrect build commands, unsure) even when using check-openmp/check-runtime, so I tend to compile them by hand to make sure (which is a little problematic, so hopefully they run happily outside of my machine/build config).


The tests are working for lowering to FIR/HLFIR. There is an issue when lowering from MLIR to llvmIR which @skatrak had already identified in #67319.

Once the other two patches that come before it are finalised and approved, I'll work on fixing that issue and making sure the tests fully work before merging any of the patches.

Thanks.



https://github.com/llvm/llvm-project/pull/67164