[flang-commits] [flang] acbb260 - [flang][openacc][NFC] Fix TODO messages
Valentin Clement via flang-commits
flang-commits at lists.llvm.org
Tue Oct 10 10:10:32 PDT 2023
Author: Valentin Clement
Date: 2023-10-10T10:10:15-07:00
New Revision: acbb260a48ea52e7fe41a4c821477aa4751805a7
URL: https://github.com/llvm/llvm-project/commit/acbb260a48ea52e7fe41a4c821477aa4751805a7
DIFF: https://github.com/llvm/llvm-project/commit/acbb260a48ea52e7fe41a4c821477aa4751805a7.diff
LOG: [flang][openacc][NFC] Fix TODO messages
Added:
Modified:
flang/lib/Lower/OpenACC.cpp
Removed:
################################################################################
diff --git a/flang/lib/Lower/OpenACC.cpp b/flang/lib/Lower/OpenACC.cpp
index c1c5980a1383dd9..61a1b9fd86717cb 100644
--- a/flang/lib/Lower/OpenACC.cpp
+++ b/flang/lib/Lower/OpenACC.cpp
@@ -566,7 +566,7 @@ mlir::acc::FirstprivateRecipeOp Fortran::lower::createOrGetFirstprivateRecipe(
recipe.getCopyRegion().front().getArgument(1));
} else if (auto seqTy = mlir::dyn_cast_or_null<fir::SequenceType>(ty)) {
if (seqTy.hasDynamicExtents())
- TODO(loc, "private recipe of array with dynamic extents");
+ TODO(loc, "firstprivate recipe of array with dynamic extents");
mlir::Type idxTy = builder.getIndexType();
mlir::Type refTy = fir::ReferenceType::get(seqTy.getEleTy());
mlir::Value arraySrc = recipe.getCopyRegion().front().getArgument(0);
@@ -598,7 +598,7 @@ mlir::acc::FirstprivateRecipeOp Fortran::lower::createOrGetFirstprivateRecipe(
fir::SequenceType seqTy =
mlir::dyn_cast_or_null<fir::SequenceType>(innerTy);
if (!seqTy)
- TODO(loc, "Unsupported boxed type in OpenACC reduction");
+ TODO(loc, "Unsupported boxed type in OpenACC firstprivate");
if (allConstantBound) {
for (auto bound : llvm::reverse(bounds)) {
@@ -916,7 +916,7 @@ static mlir::Value genReductionInitRegion(fir::FirOpBuilder &builder,
return declareOp.getBase();
} else if (auto seqTy = mlir::dyn_cast_or_null<fir::SequenceType>(ty)) {
if (seqTy.hasDynamicExtents())
- TODO(loc, "private recipe of array with dynamic extents");
+ TODO(loc, "reduction recipe of array with dynamic extents");
if (fir::isa_trivial(seqTy.getEleTy())) {
mlir::Value alloca = builder.create<fir::AllocaOp>(loc, seqTy);
auto shapeOp = genShapeOp(builder, seqTy, loc);
More information about the flang-commits
mailing list