[flang-commits] [flang] [flang] use TBAA Forest in TBAABuilder (PR #68437)

[Slava Zakharin via flang-commits]

================
@@ -39,26 +49,10 @@ static llvm::cl::opt<unsigned>
 namespace fir {
 
 TBAABuilder::TBAABuilder(MLIRContext *context, bool applyTBAA)
-    : enableTBAA(applyTBAA && !disableTBAA) {
+    : enableTBAA(applyTBAA && !disableTBAA),
+      trees(/*separatePerFunction=*/perFunctionTBAATrees) {
----------------
vzakhari wrote:

Thanks for explaining.  My only concern is a "clean" switch back to the previous state of things (e.g. to triage new failures, if any).  With this change, we will have to specify two options to switch to the TBAA that we currently have, i.e. we will have to disable the new FIR TBAA pass, and also disable the per-function behavior for the codegen.  It is not a big deal, I just wanted to confirm that this is the case.

https://github.com/llvm/llvm-project/pull/68437