[flang-commits] [mlir] [flang] [mlir] Expose type and attribute names in the MLIRContext and abstract type/attr classes (PR #72189)

Fehr Mathieu via flang-commits flang-commits at lists.llvm.org
Wed Nov 29 20:09:36 PST 2023


math-fehr wrote:

> > Do you think that makes more sense for this PR?
> 
> We could if we're confident this is enough. The API should then take a "StringLiteral" (it's more specific than a StringRef) I believe.

I'm confident `StringRef` will work, since it works for both statically-defined and dynamically defined types and attributes.
For `StringLiteral`, it wouldn't work for dynamically defined attributes and types.

https://github.com/llvm/llvm-project/pull/72189


More information about the flang-commits mailing list