[flang-commits] [libc] [compiler-rt] [lldb] [llvm] [flang] [libcxx] [clang] [clang-tools-extra] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

[Vlad Serebrennikov via flang-commits]

Endilll wrote:

Your reasoning works until we have a crash that relies on `#embed` and/or its contents.

>From what I saw triaging old crashes, crash submitters are conscious if they work with proprietary code they can't share even a fragment of, and not so rarely reduce crash by themselves. I'm not fond of the idea on giving up on every embed-related crash, because there is a risk (which I'm not estimating high), that submitter forgot to check their otherwise open code for sensitive information. This doesn't help us ironing out bugs in `#embed` implementation in the long run.

One might say that additional back-and-forth with crash submitter is not too big of a deal, and it would be, if we haven't had ever-growing backlog of issues, some dating back more than a decade. Our existing workflow that allows people to drop attachments on us and forget about it has proven itself useful in the very long run. So I'd like us to keep this.

https://github.com/llvm/llvm-project/pull/68620