[flang-commits] [clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

Andrzej Warzyński via flang-commits flang-commits at lists.llvm.org
Sun Nov 26 07:57:44 PST 2023


banach-space wrote:

> > LGTM, thank you for taking care of this 🙏🏻
> > Dare I ask - what's "dupes"? I only found [dupe](https://dictionary.cambridge.org/dictionary/english/dupe). Also, please wait for @kiranchandramohan to approve before merging this :)
> 
> I used "dupes" in the sense of being fooled. I can of course still change the name to something like "main_linktime_duplicate.f90" or the likes.

Right, "dupes" wasn't that obvious to me :) I would probably go for your other suggestion or just plain "duplicate_main.f90". Either would be a bit more descriptive IMHO 🙏🏻 .

Thanks again for addressing my comments and for this contribution!

https://github.com/llvm/llvm-project/pull/73124


More information about the flang-commits mailing list