[flang-commits] [flang] [flang] Make .exe extension of the linker optional (NFC) (PR #73157)

via flang-commits flang-commits at lists.llvm.org
Wed Nov 22 10:21:41 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-flang-driver

Author: None (kkwli)

<details>
<summary>Changes</summary>

The change in https://github.com/llvm/llvm-project/commit/34e4e5eb70818 breaks our local build that uses `-DCLANG_DEFAULT_LINKER=lld`. Although there is an open issue (https://github.com/llvm/llvm-project/issues/73153) related to `CLANG_DEFAULT_LINKER` and `FLANG_DEFAULT_LINKER`, the name of the linker may not have the `.exe` extension.

---
Full diff: https://github.com/llvm/llvm-project/pull/73157.diff


1 Files Affected:

- (modified) flang/test/Driver/dynamic-linker.f90 (+1-1) 


``````````diff
diff --git a/flang/test/Driver/dynamic-linker.f90 b/flang/test/Driver/dynamic-linker.f90
index 2745822dc107769..df119c22a2ea516 100644
--- a/flang/test/Driver/dynamic-linker.f90
+++ b/flang/test/Driver/dynamic-linker.f90
@@ -15,6 +15,6 @@
 ! GNU-LINKER-OPTIONS-SAME: "-rpath" "/path/to/dir"
 
 ! For MSVC, adding -static does not add any additional linker options.
-! MSVC-LINKER-OPTIONS: "{{.*}}link.exe"
+! MSVC-LINKER-OPTIONS: "{{.*}}link{{(.exe)?}}"
 ! MSVC-LINKER-OPTIONS-SAME: "-dll"
 ! MSVC-LINKER-OPTIONS-SAME: "-rpath" "/path/to/dir"

``````````

</details>


https://github.com/llvm/llvm-project/pull/73157


More information about the flang-commits mailing list