[flang-commits] [flang] [flang] Move internal Fortran::ISO namespace out of user-facing ISO_F… (PR #72909)

[Pete Steinfeld via flang-commits]

https://github.com/psteinfeld requested changes to this pull request.

Thanks for the fast response!

Line 172 of the updated version of `ISO_Fortran_binding.h `defines the macro `CFI_CDESC_T` using `::Fortran::ISO::cfi_internal...`  This no longer works because the namespaces `Fortran` and `ISO` have been removed.

Also, existing C++ code that wraps an include of `ISO_Fortran_binding.h `with `extern "C"`will stil l run into problems because it will think that the header file contains pure C code.  That is, it will not allow templates or namespaces.  This has the relatively easy fix of just removing the `extern "C"` declaration, though.

https://github.com/llvm/llvm-project/pull/72909