[flang-commits] [mlir] [flang] Make MLIR Value more consistent in terms of `const` "correctness" (NFC) (PR #72765)

[David Blaikie via flang-commits]

================
@@ -335,8 +335,9 @@ namespace llvm {
     MutableArrayRef(T *begin, T *end) : ArrayRef<T>(begin, end) {}
 
     /// Construct a MutableArrayRef from a SmallVector.
-    /*implicit*/ MutableArrayRef(SmallVectorImpl<T> &Vec)
-    : ArrayRef<T>(Vec) {}
+    template <typename U>
+    /*implicit*/ MutableArrayRef(const SmallVectorTemplateCommon<T, U> &Vec)
+        : ArrayRef<T>(Vec) {}
----------------
dwblaikie wrote:

> Also we can go all the way with unit-tests, but that's not the historical practice though

For the core ADTs we've been pretty good about it, I think. They're generally pretty easy to test (or should be), etc. I get that adding unit test coverage to more complex data structures that aren't so easily isolated isn't as simple. 

https://github.com/llvm/llvm-project/pull/72765