[flang-commits] [flang] [flang] Fix flang tests on MacOS (PR #70811)
Andrzej WarzyĆski via flang-commits
flang-commits at lists.llvm.org
Mon Nov 13 04:43:19 PST 2023
================
@@ -1,4 +1,5 @@
-! UNSUPPORTED: system-windows
+! MacOS needs -isysroot <osx_sysroot> with clang and flang to build binaries.
----------------
banach-space wrote:
OK, makes sense.
Please note that right now this change is completely unrelated to what this patch is trying to achieve (from the summary):
> Skip unsupported flang tests on MacOS.
You can fix that by either:
* updating the summary (to make it clear to our future selves that additional improvement is intended), or * by sending this change as a separate patch.
Whatever works better for you :) I just want to make sure that there's a clear "why" behind every change in a commit summary (folks rely heavily on that kind of documentation).
https://github.com/llvm/llvm-project/pull/70811
More information about the flang-commits
mailing list