[flang-commits] [flang] [Flang] Add partial support for lowering procedure pointer assignment. (PR #70461)

[Daniel Chen via flang-commits]

================
@@ -870,6 +878,22 @@ static PreparedDummyArgument preparePresentUserCallActualArgument(
   // element if this is an array in an elemental call.
   hlfir::Entity actual = preparedActual.getActual(loc, builder);
 
+  // Handles the procedure pointer actual/dummy arguments.
+  // It could have a combination of
+  //     acutal             dummy
+  // 2.  procedure pointer  procedure pointer
+  // 3.  procedure pointer  procedure
+  // 4.  procedure          procedure pointer
+  if (hlfir::isBoxProcAddressType(actual.getType()) ||
+      hlfir::isBoxProcAddressType(dummyType)) {
+    if (actual.getType() != dummyType &&
+        hlfir::isBoxProcAddressType(actual.getType())) {
+      auto baseAddr{actual.getFirBase()};
+      actual = hlfir::Entity{builder.create<fir::LoadOp>(loc, baseAddr)};
+    }
+    return PreparedDummyArgument{actual, /*cleanups=*/{}};
+  }
----------------
DanielCChen wrote:

Thanks Jean. This code is indeed problematic and the procedure to procedure pointer case doesn't work as you expected.
I am currently preparing an update commit that addressed most of the other issues.
I will continue working on the argument passing after I pushed that one up.

https://github.com/llvm/llvm-project/pull/70461